.htaccess support for OpenLiteSpeed webservers. #24666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current rewrite rules existing in the created .htaccess files are only supported for Apache webservers, and leaves files exposed on OpenLiteSpeed webservers by default. This is the easiest way to add support for OpenLiteSpeed 1.4.38+.
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
Jenkins add to whitelist |
|
jenkins, test this please |
|
I'm going to merge because it has no effect on apache 2.4 and I happen to still have a copy of apache 2.2 on my computer and the .htaccess still restricts properly there. And we know nginx is unaffected. |
|
@kaspernowak Can you do another PR to add yourself to https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml, for release note credits etc ? |
Merged
|
@demeritcowboy thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The current rewrite rules existing in the created .htaccess files are only supported for Apache webservers, and leaves files exposed on OpenLiteSpeed webservers by default. This is the easiest way to add support for OpenLiteSpeed 1.4.38+.
This pull request was born from this mattermost chat discussion
Before
Before the rewrite rules for OpenLiteSpeed are added to the .htaccess files, the CiviCRM system status produces warnings about Private Files being Readable when running on a drupal 9 site on a OpenLiteSpeed webserver.
After
After the rewrite rules for OpenLiteSpeed are added to the .htaccess files, the CiviCRM system status no longer produces warnings about Private Files being Readable when running on a drupal 9 site on a OpenLiteSpeed webserver.
Notes
To make sure this will work on OpenLiteSpeed,
Enable RewriteandAuto Load from .htaccesshas to be set toYesin the Rewrite Control settings of the vhost.