Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3829 Fix semi-recent regression on event badge #24695

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 8, 2022

Overview

dev/core#3829 Fix semi-recent regressions on event badge

There are two issues

Firstly the default data on a new install does not load well when the screen is loaded - per the screenshot below. Secondly the barcode no longer contains contact id & participant ID.

I didn't know that we did bar codes but it turns out that if you do a participant search and choose the event badge action you can opt to have a barcode on it. I found I could upload the resulting pdf to this site - https://online-barcode-reader.inliteresearch.com/ to read it.

image

However, you can also visually see the barcode is shorter - the one with less data

image

image

Before

The json in the data field is lacking appropriate escaping around the double quotes resulting in it not unpacking

image

Secondly the pdfs are missing detail in the barcode per
https://lab.civicrm.org/dev/core/-/issues/3829

After

image

Technical Details

Note regen not included in the PR due to likely merge conflicts - will follow

Comments

@civibot
Copy link

civibot bot commented Oct 8, 2022

(Standard links)

@civibot civibot bot added the master label Oct 8, 2022
@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.55 October 8, 2022 15:05
@civibot civibot bot added 5.55 and removed master labels Oct 8, 2022
@demeritcowboy
Copy link
Contributor

Note if you're using the test site here it's sort of mentioned in the PR description but you need to create a new badge layout from scratch - if you use the existing one you get a blank pdf and trying to edit the layout gives an error. (Side-note: I thought I had changed the default font to deja-vu a few years ago so that unicode works - it's now defaulting to the first one in the list. TBD.)

@demeritcowboy demeritcowboy merged commit 30ebb8e into civicrm:5.55 Oct 9, 2022
colemanw added a commit that referenced this pull request Oct 9, 2022
@eileenmcnaughton eileenmcnaughton deleted the badge-master branch October 10, 2022 07:29
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy - yeah - I was thinking the sql would go stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants