Fix language negotiation exception to be standard

[eileenmcnaughton]

Overview

Fix language negotiation exception to be standard

Before

CRM_Core_Locale::negotiate throws a RunTime exception when provided bad data

After

CRM_Core_Locale::negotiate throws a CRM_Core_Exception

Technical Details

`RunTime exceptions are defined as
"Exception thrown if an error which can only be found on runtime occurs."

I guess you could argue that any place in the code that fails when data is bad / fails validation is a runTime exception - but in practice in our codebase historical bad database data (e.g having an invalid value in civicrm_contact.preferred_language or an invalid email would generally throw a CRM_Core_Exception and most code that calls CiviCRM function expects and handles this). Where I see runTime exceptions in Civi code is mostly where a site is misconfigured - so not something that an extension would need to know about or handle.

This function is a utility function that is frequently called from sending messages & it seems wrong to have an exception thrown that bypasses 99% of civicrm exception handling

Side note - the type of exception thrown should have been documented in the docblock & we should possibly document the reason whenever it isn't a derivative of CRM_Core_Exception

Comments

@totten

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[wikimediaWfan]

Ha right, this error exception is not about runtime error

[totten]

Side note - the type of exception thrown should have been documented in the docblock & we should possibly document the reason whenever it isn't a derivative of CRM_Core_Exception

Heh - The main reason to use RuntimeException is that it doesn't require a docblock. 🙃

(I kid, but it's true. You can play with it in the PhpStorm to see -- Exceptions will follow you around with docblocks and warnings, but RuntimeExceptions won't. PhpStorm's behavior makes much more sense if you interpret Exception/RuntimeException from Java perspective - ie checked vs unchecked. Granted, in PHP's runtime, they don't really have "checked" exceptions -- so it only makes a difference in how the IDE presents it.)

In any event, you're right that everything else is CRM_Core_Exception - so this might as well be too.

[eileenmcnaughton]

@totten ok to merge then?