(WIP) Convert Administer Option Groups/Values partially to SK #25180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance OptionGroup metadata Make view, add, edit options work via `civicrm/admin/options/edit` URL
|
(Standard links)
|
|
@colemanw Here's a first attempt at disentangling some of the OptionGroup/OptionValue complexity and moving it to SearchKit. Does the approach make sense? |
Some OptionGroups have paths (defined in xml) for specific handling.
CRM_Admin_Page_Options is called many ways. The intent is to allow
those with non-specific handling to be processed via SK while others
go through the legacy route.
It does this by creating alias URL's for civicrm/admin/options/{edit,add,update,delete}
With the extension enabled, 'civicrm/admin/options' provides the
OptionGroup listing.
OptionValue links go to 'civicrm/admin/options/edit' and handled by SK -
unless they have special handling in which case they go to the legacy
URL's. The appropriate link is determined by a new Calculated Field
OptionGroup.edit_link
|
@aydun there's a lot going on here but what about a PR just for updating the OptionGroup DAO metadata. |
aydun
added a commit
to aydun/civicrm-core
that referenced
this pull request
Dec 16, 2022
Extracted from civicrm#25180
aydun
added a commit
to aydun/civicrm-core
that referenced
this pull request
Dec 16, 2022
Extracted from civicrm#25180
aydun
added a commit
to aydun/civicrm-core
that referenced
this pull request
Jan 12, 2023
Extracted from civicrm#25180
|
Can one of the admins verify this patch? |
|
See #25387 |
larssandergreen
pushed a commit
to larssandergreen/civicrm-core
that referenced
this pull request
Jan 24, 2023
Extracted from civicrm#25180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This moves the listing of Option Groups and Option Values in the Administer menus to SearchKit.
Viewing of individual Option Groups & Values is still done by the old forms as is creation of new Groups & Values.
Before
civicrm/admin/optionsand related links all handled by old worldAfter
civicrm/admin/optionsand some related links handled by SearchKitTechnical Details
This tries to allow OptionGroups and OptionValues to be listed via SearchKit
Some OptionGroups have paths (defined in xml) for specific handling.
CRM_Admin_Page_Optionsis called many ways. The intent is to allowthose with non-specific handling to be processed via SearchKit while others
go through the legacy route. Hopefully most of the special handling can be removed in a later phase.
It does this by creating alias URL's for
civicrm/admin/options/{edit,add,update,delete}With the extension enabled,
civicrm/admin/optionsprovides theOptionGroup listing.
OptionValue links go to
civicrm/admin/options/editand handled by SearchKit -unless they have special handling in which case they go to the legacy
URL's. The appropriate link is determined by a new Calculated Field
OptionGroup.edit_linkComments
descriptionfield but we need a way to display that in the help text area. See Add Option Group descriptions from templates/CRM/Admin/Page/Options.tpl #25143[option_group_id]token is not replaced. This is working in the comparable Add CustomField display but there's some magic missing!ts()'s but we probably need other changes.