[NFC] php8 - Unit test for empty checkbox array #23305 #25201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
As expected: The second fail is fallout from the first fail causing transaction issues. |
demeritcowboy
force-pushed
the
empty-checkbox
branch
from
edf12b8 to
7bc341d
Compare
demeritcowboy
changed the title
|
This should pass now. Jenkins retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
To create a contact with a custom checkbox field where none of the boxes are checked, or update a contact where there are some checked to be unchecked, you can pass in
'custom_1' => []as one of the params, but this crashes in php 8.Before
TypeError: mysqli_real_escape_string(): Argument #2 ($string) must be of type string, array given ... vendor\pear\db\DB\mysqli.php:880After
Technical Details
As noted in #23305, the problem is in the format function. Normally it would convert an array to a string in this situation, but it skips doing that because it returns too early, so ends up passing on an array to escapeString() later.
Comments
Is Test