Remove broken method CRM_Utils_File::isHtml() #25233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
It's not used in universe. Yeah this came up in passing before: #22425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove broken method CRM_Utils_File::isHtml()
Before
The method
CRM_Utils_File::isHtml()referencedCRM_Utils_String::isHtml($line)which does not exist (and has not existed for at least 10 years, and maybe never). ThereforeCRM_Utils_File::isHtml()won't work as expected.After
The method is gone.
Comments
Usually when removing a method, the correct thing to do would be to initially deprecated it. However, given how broken the method appears, I thought it was probably ok to just remove it. That said, it might be worth someone doing a check on universe (I don't have it setup myself).