dev/core#4419 - Crash on membership tab of contribution page config (should go into 5.64)

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/4419

Before

1. php8 - open membership tab in contribution page config
2. crash

After

Technical Details

Pretty much the same as #26517

Comments

[civibot]

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

• If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• Here are some handy links for reviewers:
  • Demo site for this PR
  • Review standards
  • Review template

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4419

[larssandergreen]

Not again! Works for me, good to go.

[demeritcowboy]

Actually wait I think this needs to be 5.63. I'm getting confused about what version is what now.

[demeritcowboy]

Ok so the issue started in 5.63, but this master is now the RC, so this is right, and then it needs to be backported after to 5.63.

[colemanw]

Thanks @demeritcowboy can you also open a PR for the backport?

[demeritcowboy]

Backport: #26759