CRM-19556 : Allow to search on just being an active member #9314
Conversation
liedekef
commented
Oct 24, 2016
•
liedekef
commented
- CRM-19556: Allow to search on active membership
| case 'membership_is_current_member': | ||
| // We don't want to include all tests for sql OR CRM-7827 | ||
| $query->_where[$grouping][] = CRM_Contact_BAO_Query::buildClause("civicrm_membership_status.is_current_member", $op, $value, "Boolean"); | ||
| $query->_qill[$grouping][] = ts('Active Member'); |
There was a problem hiding this comment.
only thing this should change if $value = 0 then it should be Inactive Member
There was a problem hiding this comment.
something like
$query->_qill[$grouping][] = ts('Is a Active Member? %1', array(1 => $value ? 'Yes' : 'No'));
??
There was a problem hiding this comment.
Check my latest commit and see if that is ok
|
@liedekef there is a style warning highlighted in the related test build failure https://test.civicrm.org/job/CiviCRM-Core-PR/12408/ |
|
Changes look good, tested on local
|
|
Ok, I'll fix the styling issues asap. Does the "merge on pass" mean that the PR will be immediately merged if all checks have passed? |
|
Yup exactly :) As when you fix the style error and push commit, test will re-build and if everything goes well it will be merged by me or other civicrm mergers. |
|
I opened #9457 to address some wording issues. |
