Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19587, donot delete financial account if its present in civicrm_f… #9342

Merged
merged 3 commits into from
Nov 3, 2016

Conversation

pradpnayak
Copy link
Contributor

…inancial_item table


@yashodha yashodha added the master label Nov 1, 2016
@yashodha
Copy link
Contributor

yashodha commented Nov 1, 2016

@pradpnayak Can you provide test coverage for the same?

@pradpnayak
Copy link
Contributor Author

Added CRM test

Copy link
Contributor

@JoeMurray JoeMurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we separate the PR for the functional change from the code cleanup changes. BTW, lots very useful code cleanup - thanks.

…inancial_item table

----------------------------------------
* CRM-19587: DB Error when trying to delete FInancial Account
  https://issues.civicrm.org/jira/browse/CRM-19587
----------------------------------------
* CRM-19587: DB Error when trying to delete FInancial Account
  https://issues.civicrm.org/jira/browse/CRM-19587
----------------------------------------
* CRM-19587: DB Error when trying to delete FInancial Account
  https://issues.civicrm.org/jira/browse/CRM-19587
@pradpnayak
Copy link
Contributor Author

Separated PR at #9346

@yashodha yashodha merged commit da1c059 into civicrm:master Nov 3, 2016
@pradpnayak pradpnayak deleted the CRM-19587 branch February 22, 2017 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants