Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19629 Labels display as pills on joomla backend civicrm pages #9365

Merged
merged 2 commits into from
Nov 15, 2016

Conversation

alifrumin
Copy link
Contributor

@alifrumin alifrumin commented Nov 8, 2016

Joomla uses bootstrap (http://getbootstrap.com/) on the backend to style things and the bootstrap styles of labels overide civiCRM's styling of labels and make labels into little inline pill like things, this resets the styling to the civi version of what a label is (only on civi pages)

before:
image

after:
cleanerregisterparticipantpage


@alifrumin alifrumin changed the title bootstrap styles being applied to labels on the backend in joomla CRM-19629 Labels display as pills on joomla backend civicrm pages Nov 10, 2016
width: inherit;
}

#crm-container .label {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the class selector .crm-container will include popups. The id selector #crm-container is only for the main content area.

@@ -375,3 +375,13 @@ ul#civicrm-menu li#crm-qsearch {
.crm-container .disabled {
font-weight: normal;
}

#crm-container .crm-container .form-layout td.label {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be on two lines to get both cases, like

#crm-container .form-layout td.label,
.crm-container .form-layout td.label {

@alifrumin
Copy link
Contributor Author

Thank you for the tips @colemanw, I made the changes you suggested.

@colemanw colemanw merged commit 47494d2 into civicrm:master Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants