Use correct user variable in hook_user_insert

[demeritcowboy]

$user is never defined anywhere.

It ends up not making a difference when creating drupal users via UI because the only thing it changes in synchronizeUFMatch is that it reassigns $uniqId (the email address) to $params['email'] a second time before calling Contact.create. i.e. once here and then again here.

The Drupal vs Drupal8 also doesn't make a difference because that param is only used when it's wordpress or joomla.

This surfaced because of civicrm/civicrm-core#23515. There aren't any tests in this repo but there are tests elsewhere that failed, e.g. https://github.com/SemperIT/CiviCARROT/runs/6566995948?check_suite_focus=true#step:19:44, where the drupal user isn't created in the UI.

[KarinG]

Also seeing it in WFC ->

[KarinG]

Drupal\Core\Entity\EntityStorageException: Mandatory key(s) missing from params array: one of (first_name, last_name, email, display_name)

[demeritcowboy]

Noting you can also reproduce the fail with drush:

drush user-create abc --password=12345 --mail=a@b.org

[demeritcowboy]

Thanks @eileenmcnaughton @KarinG

[KarinG]

Thank you Dave! Re-running WFC tests now to tripple confirm.

[eileenmcnaughton]

@demeritcowboy @KarinG does this only affect d8 - i saw a comment on chat that it might not?

[KarinG]

Sorry - comment was about the Student vs student and the excessive use of strtolower in WFC -> that dates back to D7.

I’m not sure about this PR/issue affecting D7 - Dave?

[demeritcowboy]

It would have come up in core tests since drush creates the webtest user during those runs, but no the drupal 7 code looks ok to me.

[eileenmcnaughton]

is it surprising that this was wrong for so long & not found until the change I made?