Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header sizing accessibility issues #1101

Closed
3 tasks
bruceplai opened this issue Dec 13, 2021 · 3 comments · Fixed by #1160
Closed
3 tasks

Header sizing accessibility issues #1101

bruceplai opened this issue Dec 13, 2021 · 3 comments · Fixed by #1160
Assignees
Labels
role: UI/UX size: 3pt Can be done in about 18 hours

Comments

@bruceplai
Copy link
Member

bruceplai commented Dec 13, 2021

Overview

Accessibility tools are flagging possible header sizing issues. h tag values should be sequentially increasing or at least increasing as you dig deeper into a page structure. This is according to various accessibility scanning tools.

Action Items

  • Decide (with UI/UX and PM input) if any page header sizing updates should be done
  • Update figma header sizes accordingly
  • Update any pages to match figma

Resources/Instructions

image
image

@bruceplai bruceplai added role: UI/UX size: 3pt Can be done in about 18 hours labels Dec 13, 2021
@bruceplai bruceplai added this to the 7 - MVP Website Launch milestone Dec 13, 2021
@chalimar
Copy link
Member

Thank you for reviewing, Bruce! I have created a new type scale and hope that it might be applicable to fixing some of these issues.

Will connect with you at the meeting.

Screen Shot 2021-12-13 at 12 04 05 PM

@smsada
Copy link
Member

smsada commented Feb 11, 2022

Made Duplicate issue from #1150

Overview

Screen readers interpret page structure based on Hx tags which need to be separated from title size tags.

Description

  • Use Hx tags in conjunction with Title classes.
    • Hx tags should be used to communicate hierarchical information
    • Title classes are used to control size
  • Currently incorrectly implementing Hierachrial tags (H1, H2, etc.)
  • Important for screen readers as Hx classes are used for page structure (Headings and Subheadings) while the title class will control the size
  • Example of currently incorrect page structure using Hx tags is the Collaborate page
Collaborate page using H4 tag instead of title class tag

image

Action Items

  • Review existing classes to identify if title 1 - 6 have been created
  • Consider implementation via Aria Level tags vs Title Classes
  • Make issues to revise each page on the website to use the appropriate combination of Hx tags and Title classes
    • Add links to each of those issues to this epic issue

Resources/Instructions

Title Classes screenshot from CTI figma

image

@bruceplai
Copy link
Member Author

  1. Progress - Still investigating using aria-level
  2. Blockers - none
  3. Availability - 2 days
  4. ETA - will try by next meeting

bruceplai added a commit that referenced this issue Feb 17, 2022
* Set aria-level values in multiple pages

* Some code formatting
bruceplai added a commit that referenced this issue Feb 17, 2022
* Set aria-level values in multiple pages

* Some code formatting
bruceplai added a commit that referenced this issue Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: UI/UX size: 3pt Can be done in about 18 hours
Projects
Development

Successfully merging a pull request may close this issue.

4 participants