Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember orgs page state (#1081) #1156

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Remember orgs page state (#1081) #1156

merged 3 commits into from
Feb 17, 2022

Conversation

bruceplai
Copy link
Member

Closes #1081

  • Store org search query in url param

  • Store open orgs in url param

  • State/props cleanup

* Store org search query in url param

* Store open orgs in url param

* State/props cleanup
@bruceplai bruceplai requested review from bhaggya, mealthebear and maxskewes and removed request for bhaggya, mealthebear and maxskewes February 11, 2022 17:53
Copy link
Contributor

@bhaggya bhaggya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed and it is working fine

@bruceplai
Copy link
Member Author

I just reviewed and it is working fine

Thanks for the review. If the PR is good to merge could you approve it?

@codeclimate
Copy link

codeclimate bot commented Feb 16, 2022

Code Climate has analyzed commit 642cc95 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 89.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.7% (0.0% change).

View more on Code Climate.

@bruceplai bruceplai merged commit 0ec4bf9 into main Feb 17, 2022
@bruceplai bruceplai deleted the orgs-page-state-1081 branch February 17, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Organizations page to track user behavior in URL
2 participants