Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the usage of swapping ContextClassLoader #23

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Limit the usage of swapping ContextClassLoader #23

merged 2 commits into from
Mar 10, 2020

Conversation

civitaspo
Copy link
Owner

[Enhancement] Limit the usage of swapping ContextClassLoader

@civitaspo civitaspo merged commit 9aefba9 into develop Mar 10, 2020
@civitaspo civitaspo deleted the limit-the-usage-of-ContextClassLoader branch March 10, 2020 09:26
@civitaspo civitaspo mentioned this pull request Mar 10, 2020
Merged
@civitaspo
Copy link
Owner Author

civitaspo commented Mar 10, 2020 •
edited
Loading

See these conversations.

In summary, swapping ContextClassLoader in this plugin means swapping embulk-core ClassLoader, so this plugin's dependencies affect other plugins. On the other hand, some parquet dependencies depend on ContextClassLoader. That's why swapping ContextClassLoader should be limited, not forbidden.

@civitaspo civitaspo mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@civitaspo