Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Glue data type #47

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Rename Glue data type #47

merged 2 commits into from
Jun 24, 2020
+17 −17

Conversation

tksfjt1024
Copy link
Contributor

Athena doesn't support uppercase letters and spaces.

civitaspo
civitaspo reviewed Jun 24, 2020
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
civitaspo
civitaspo requested changes Jun 24, 2020
View reviewed changes
Copy link
Owner

@civitaspo civitaspo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There is nothing wrong with this change. Could you revert only the version-related changes?

@civitaspo civitaspo self-requested a review June 24, 2020 02:33
@civitaspo
Copy link
Owner

I do not know why GHA does not run, but I checked the tests for your PR locally, so ship it.

@civitaspo civitaspo merged commit eda50a2 into civitaspo:master Jun 24, 2020
@civitaspo civitaspo mentioned this pull request Jun 24, 2020
Merged
@civitaspo
Copy link
Owner

Released https://github.com/civitaspo/embulk-output-s3_parquet/releases/tag/0.5.1

@tksfjt1024
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@civitaspo civitaspo Awaiting requested review from civitaspo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tksfjt1024 @civitaspo