Skip to content

civo: add ascii logo #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

shivarm
Copy link
Contributor

@shivarm shivarm commented Sep 18, 2023

No description provided.

@shivarm
Copy link
Contributor Author

shivarm commented Sep 18, 2023

review\ @alejandrojnm @saiyam1814 @vishalanarase

Copy link
Member

@alessandroargentieri alessandroargentieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you straighten the word (now it's not well formatted) and write Civo CLI I'll approve and merge. Thanks for the nice idea.

@shivarm
Copy link
Contributor Author

shivarm commented Jan 10, 2024

@alessandroargentieri can we merge it?

@alessandroargentieri
Copy link
Member

@shivam-sharma7 I see the label is not well formatted. This is the last version you proposed:

~/tests/cli_test/cli (⌥ ascii-art-logo) $ go run main.go version --verbose

	   _____  _                  _____  _       _____ 
  / ____|(_)                / ____|| |     |_   _|
 | |      _ __   __  ___   | |     | |       | |  
 | |     | |\ \ / / / _ \  | |     | |       | |  
 | |____ | | \ V / | (_) | | |____ | |____  _| |_ 
  \_____||_|  \_/   \___/   \_____||______||_____|

Copy link
Member

@alessandroargentieri alessandroargentieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first line is completely shifted

@shivarm
Copy link
Contributor Author

shivarm commented Jan 11, 2024

@alessandroargentieri formattted

@alessandroargentieri
Copy link
Member

@shivam-sharma7 may you paste what you're getting? After pulling your branch is still unformatted from my side...

@shivarm
Copy link
Contributor Author

shivarm commented Jan 11, 2024

@shivam-sharma7 may you paste what you're getting? After pulling your branch is still unformatted from my side...

please check again.

Copy link
Member

@alessandroargentieri alessandroargentieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessandroargentieri alessandroargentieri merged commit 8995e3d into civo:master Jan 11, 2024
@shivarm shivarm deleted the ascii-art-logo branch January 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants