Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Database #162

Merged
merged 7 commits into from
Jan 24, 2023
Merged

Added support for Database #162

merged 7 commits into from
Jan 24, 2023

Conversation

satakshigarg
Copy link
Contributor

Terraform support for Database as a Service
Signed-off-by: satakshigarg satakshi@civo.com

Signed-off-by: satakshigarg <satakshi@civo.com>
Copy link
Member

@alejandrojnm alejandrojnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need fix all the comment but in general look good to me

civo/datasource_database.go Outdated Show resolved Hide resolved
civo/resource_database.go Outdated Show resolved Hide resolved
satakshigarg and others added 6 commits January 19, 2023 15:01
Signed-off-by: satakshigarg <satakshi@civo.com>
Signed-off-by: satakshigarg <satakshi@civo.com>
Signed-off-by: satakshigarg <satakshi@civo.com>
Signed-off-by: satakshigarg <satakshi@civo.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
@alejandrojnm
Copy link
Member

@satakshigarg @RealHarshThakur this is ready to review and merge, I run the ACC test locally and every test pass

@satakshigarg
Copy link
Contributor Author

LGTM @alejandrojnm

@alejandrojnm alejandrojnm merged commit 2af28da into master Jan 24, 2023
@alejandrojnm alejandrojnm deleted the Database_Support branch January 24, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants