Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception thrown when Playing playlist item #35

Closed
cjam opened this issue Mar 22, 2020 · 1 comment
Closed

Exception thrown when Playing playlist item #35

cjam opened this issue Mar 22, 2020 · 1 comment
Assignees
@cjam
Labels
bug Something isn't working

Comments

@cjam
Copy link
Owner

cjam commented Mar 22, 2020

When playing a playlist item, the library fails on converting the PlayerState that is emitted on the change.
@cjam cjam added the bug Something isn't working label Mar 22, 2020
@cjam cjam self-assigned this Mar 22, 2020
@cjam
Copy link
Owner Author

cjam commented Mar 22, 2020

This was due to playlists triggering playerState changes with artists and albums that contained nil values. Check for them and return blank strings instead.

cjam added a commit that referenced this issue Mar 22, 2020
@cjam
#35 handle nils in player state
d44af28
@cjam cjam mentioned this issue Mar 22, 2020
Merged
cjam added a commit that referenced this issue Mar 22, 2020
@cjam
Fix/safer api use (#36)
e9baef6 
* Small updates to example

* #35 handle nils in player state

* #32 Wrap api calls in checks to reject on unready

* Bumping version and adding changelogs
@cjam cjam closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjam cjam

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjam