gradle flatDir to sourceSets #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Is this supported by older versions of Gradle / do we need to worry about it breaking for older RN projects? |
|
SourceSets is supported from gradle-2.10. This change won't be a problem for projects using gradle version above this. |
ahbou
added a commit
to TTFM-Labs/react-native-spotify-remote
that referenced
this pull request
Dec 23, 2022
* upstream/master: gradle flatDir to sourceSets (cjam#205) chore: release 1.0.0-1 Fix iOS Build (cjam#202) feat: use react-native NativeEventEmitter (cjam#189) Update gradle to direct include aar files (cjam#199) chore: release 0.3.11-6 Update contributors and changelog Add contribute script and Pull request template Add a null check when mapping tracks (cjam#192)
theshadowagent
pushed a commit
to theshadowagent/react-native-spotify-remote
that referenced
this pull request
Jan 24, 2023
* gradle flatDir to sourceSets * updated as per contributor guide
theshadowagent
added a commit
to theshadowagent/react-native-spotify-remote
that referenced
this pull request
Jan 24, 2023
This reverts commit 7c13126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes introduced in this pull request:
Tasks
yarn contributeUnreleasedsection ofCHANGELOG.mdwith changes (Convention)@cjam