Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed users to use xauth to connect. #9

Merged
merged 5 commits into from
May 5, 2019

Conversation

charlesduponpon
Copy link
Contributor

This change is backward compatible (or so I believe). I tried it locally with xauth but not with the facebook token.

From the discussion in charliewolf/pynder#211

@cjekel
Copy link
Owner

cjekel commented May 4, 2019

Ah I see that you already did make facebook_token=None optional.

@cjekel
Copy link
Owner

cjekel commented May 4, 2019

I don't have write access to your repo, but I believe the only thing this needs is a new default for XAuthToken like in ac4896f

@charlesduponpon
Copy link
Contributor Author

I believe there is an option on github to allow yourself to have write access on forks of your project. In the meantime, I sent you an invitation to collaborate.

@cjekel cjekel merged commit b7ff485 into cjekel:master May 5, 2019
@cjekel
Copy link
Owner

cjekel commented May 5, 2019

Thanks for creating the XAuth option!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants