Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gaston] Turn off auto-send by Enter #342

Closed
xqrongm opened this issue Feb 25, 2017 · 9 comments
Closed

[Gaston] Turn off auto-send by Enter #342

xqrongm opened this issue Feb 25, 2017 · 9 comments

Comments

@xqrongm
Copy link

xqrongm commented Feb 25, 2017

In students' chat interface, when students type in their answers to a question, the content is sent upon a pressing the Enter key. Students would prefer Enter resulting in a line return in the text instead of sending, and that sending should only be triggered by clicking the "Send" button or a keyboard combination such as Ctrl + Enter.

@alexbojko
Copy link
Collaborator

link with issue #199

@alexbojko
Copy link
Collaborator

this issue is already fixed in branch fix/issue199
user send data to the server only by hitting Send button, not by Enter

@alexbojko alexbojko reopened this Mar 9, 2017
alexbojko added a commit to raccoongang/socraticqs2 that referenced this issue Mar 10, 2017
…ushing ctrl+enter and enter just creates new line in response.
@cmltaWt0 cmltaWt0 assigned cmltaWt0 and unassigned cmltaWt0 Mar 11, 2017
alexbojko added a commit to raccoongang/socraticqs2 that referenced this issue Mar 14, 2017
…hatting reply it will add 1 blank line (in rst format it means new line)
@cmltaWt0 cmltaWt0 assigned alexbojko and unassigned alexbojko and cmltaWt0 Mar 14, 2017
alexbojko added a commit to raccoongang/socraticqs2 that referenced this issue Mar 15, 2017
cmltaWt0 pushed a commit to raccoongang/socraticqs2 that referenced this issue Mar 15, 2017
…ushing ctrl+enter and enter just creates new line in response.
cmltaWt0 pushed a commit to raccoongang/socraticqs2 that referenced this issue Mar 15, 2017
…hatting reply it will add 1 blank line (in rst format it means new line)
cmltaWt0 pushed a commit to raccoongang/socraticqs2 that referenced this issue Mar 15, 2017
@cmltaWt0 cmltaWt0 assigned redilonka and unassigned alexbojko Mar 15, 2017
@xqrongm
Copy link
Author

xqrongm commented Mar 17, 2017

It looks like even though Enter creates a line break when student is typing, it becomes a space after the message is sent. Instructors think it would be better for line break to stay as line break. Is it difficult to implement?

@xqrongm xqrongm reopened this Mar 17, 2017
@redilonka
Copy link
Collaborator

@xqrongm Students can create formatted answer to include some equation. So we preformat text before render. This behavior is defined.

screenshot_60

@xqrongm
Copy link
Author

xqrongm commented Mar 17, 2017

These formatting can be useful, but unfortunately most students don't have the patience to read the instruction and create formatted text accordingly. When they see line breaks become spaces, they'll just start complaining instead of doing extra formatting work to make sure line breaks stay line breaks.

@cmltaWt0
Copy link
Collaborator

cmltaWt0 commented Mar 19, 2017

@xqrongm ok, I will discuss it with Chris. Is it critical issue for us? If so - we can deploy changes as hot fix before Hedgehog release 30.03.17

@xqrongm
Copy link
Author

xqrongm commented Mar 19, 2017

Instructor hasn't indicated that this is very urgent. I believe it's more of an inconvenience than a problem. It can be fixed in the upcoming release instead of right now, unless instructors tell me otherwise in the future.

alexbojko added a commit to raccoongang/socraticqs2 that referenced this issue Mar 28, 2017
@redilonka redilonka assigned cmltaWt0 and unassigned redilonka Mar 30, 2017
@cmltaWt0
Copy link
Collaborator

cmltaWt0 commented Apr 13, 2017

@xqrongm
Decided to not disable formatting feature.
In a future something like wysiwyg editor or provide for description for Students.

@xqrongm
Copy link
Author

xqrongm commented Apr 27, 2017

For my own and instructors' reference, the format for chat content is Markdown, i.e. one line return in raw text is displayed as a space after sent, two line returns in raw text is displayed as one line return after sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants