generated from spatie/package-skeleton-laravel
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow models to require approval only when needed #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, Thanks for the PR. I am not going to be approving it as it is not achieving anything I want for this package. My suggestion is to fork this repo and use it in your project as what you're after is unique just to you. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my use case, I had many crud operations already defined for my models, and only wanted approval in certain circumstances. With this PR, approval can be turned off and on as needed by attaching the trait
MayBeApproved
.Now, in normal use, if I want to update a particular attribute of a site, it works normally (return true). When I execute the command
requireApproval()
and then update the site, it return false and inserts the Morph into the approvals table. I can turn the requirement off again withrequireApproval(false)
In addition, I can also commit changes as follows