-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not set TMPDIR when exporting to requirements.txt #298
Conversation
f4ec5de
to
0acc3e7
Compare
Just a small note. TMPDIR used to be |
@brechtm I don't think so. Try this with the previous version: from nox_poetry import session
@session
def test(session):
session.poetry.export_requirements()
session.run("python", "-c", """import os; print(f"{os.environ['TMPDIR'] = }")""") Here's the output I get:
We just used |
Ah, yes. During my testing I adjusted the nox-poetry code to create and use the |
Do not set or modify TMPDIR in Nox sessions. nox-poetry should not modify the environment of users. Fiddling with TMPDIR can also lead to issues with other tools, especially since it happened at unpredictable points in the build process.
Previously, nox-poetry set TMPDIR indirectly by invoking session.create_tmp from export_requirements. We continue to use
<venv>/tmp
but create it ourselves instead of using session.create_tmp.Closes #249