Fix broken sdist support due to missing egg fragment #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry does not include the src directory in the sdist archive, if a parent directory of the project also contains a Poetry project. This is the case because pytest-datadir copies the example project to a temporary directory, and nox_poetry sets TMPDIR to a location under the session directory, via session.create_tmp().
cjolowicz
force-pushed
the
fix-sdist-uninstall-step
branch
from
f16f788 to
56c261c
Compare
cjolowicz
force-pushed
the
fix-sdist-uninstall-step
branch
from
56c261c to
4746059
Compare
cjolowicz
added a commit
that referenced
this pull request
Mar 13, 2021
cjolowicz
added a commit
that referenced
this pull request
Mar 13, 2021
cjolowicz
added a commit
that referenced
this pull request
Mar 13, 2021
cjolowicz
added a commit
that referenced
this pull request
Mar 13, 2021
cjolowicz
added a commit
that referenced
this pull request
Mar 14, 2021
* Do not set TMPDIR when exporting to requirements.txt * Adapt unit tests * Remove obsolete workaround from #178 * Workaround an issue in Nox's types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127