Convert exported requirements to constraints format #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjolowicz
force-pushed
the
fix-invalid-constraints
branch
6 times, most recently
from
85a2577 to
54bec74
Compare
Add a failing test for URL dependencies. Test output below: nox > Command python -m pip install --constraint=.nox/test/tmp/requirements.txt file:///…/url-dependency/dist/url_dependency-0.1.0-py3-none-any.whl failed with exit code 1: DEPRECATION: Constraints are only allowed to take the form of a package name and a version specifier. Other forms were originally permitted as an accident of the implementation, but were undocumented. The new implementation of the resolver no longer supports these forms. A possible replacement is replacing the constraint with a requirement.. You can find discussion regarding this at pypa/pip#8210. ERROR: Links are not allowed as constraints
cjolowicz
force-pushed
the
fix-invalid-constraints
branch
from
54bec74 to
a06ae67
Compare
This was referenced Mar 15, 2021
Closed
Closed
Closed
JSchlensok
added a commit
to wilhelm-lab/oktoberfest
that referenced
this pull request
Aug 7, 2024
Since nox-poetry skips URL constraints (cjolowicz/nox-poetry#308), DLomix could not be installed from source in a Nox session as without a constraint, pip would fall back to PyPI. See pypa/pip#8210 and pypa/pip#8253 for further context. Manually invoking pip in a session prevents this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes installation errors due to the use of some forms of requirements as constraints that are no longer supported with pip's new dependency resolver:
Constraints are now rewritten in the form
name==version[; markers], and skipped if either name or version are empty.This PR adds a dependency on the packaging library.
Fixes #141