Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CKAN 2.11 images #69

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add CKAN 2.11 images #69

merged 2 commits into from
Jul 1, 2024

Conversation

amercader
Copy link
Member

These are the same py3.10 based ones as the master ones.

There's lots of duplicated files, we should aim to have a common directory for these unless a specific version needs to override a particular file for some reason.

These are the same py3.10 based ones as the master ones
@amercader
Copy link
Member Author

Images pushed to Docker Hub

@kowh-ai kowh-ai self-assigned this Jun 28, 2024
Copy link
Contributor

@kowh-ai kowh-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amercader - both base and dev images build OK

@kowh-ai
Copy link
Contributor

kowh-ai commented Jun 28, 2024

@amercader - images build fine however I get errors when using these 2 new images

  1. Using the base image I get an error when adding a new resource to a dataset
    Screenshot 2024-06-28 at 2 20 52 pm

  2. Using the dev image I get a different error

Screenshot 2024-06-28 at 2 35 44 pm

Screenshot 2024-06-28 at 2 35 59 pm

I can work on this next week to see what config options may be missing here

@amercader
Copy link
Member Author

Thanks @kowh-ai 1 is probably a problem with my fix in ckan/ckan#8284 and 2 looks like a networking problem with the datapusher container. I'll investigate as well

@amercader
Copy link
Member Author

Can you review and merge ckan/ckan#8310 @kowh-ai, that should take care of the first exception

@amercader
Copy link
Member Author

Just tried issue 2 and worked for me. Make sure that CKAN__DATAPUSHER__CALLBACK_URL_BASE and DATAPUSHER_REWRITE_URL are correctly set using ckan-dev instead of ckan.
We probably need separate .env.example and .env.dev.example files because there's a few of these options that are different across environments.

@amercader amercader merged commit 4da2d02 into main Jul 1, 2024
@amercader amercader deleted the 2.11-images branch July 1, 2024 12:07
@kowh-ai
Copy link
Contributor

kowh-ai commented Jul 3, 2024

@amercader - Yes all of the images work for me now (after a day of testing). I did have the same networking (cannot connect to datapusher) issues in 2.10 and 2.11 and I had updated CKAN__DATAPUSHER__CALLBACK_URL_BASE and DATAPUSHER_REWRITE_URL to use ckan-dev but they did "go away" and I couldn't recreate the same error. Anyway, I'll create a PR on the ckan-docker repo for a README change to detail what to change in the .env file when moving from base to dev mode

@amercader
Copy link
Member Author

@kowh-ai yes I had different issues when recreating environments, specially when switching between the prod/dev ones. Basically you need to remove everything including volumes to avoid issues. I suspect the site_packages one is to blame in many cases , eg packages from project images not being installed

@wardi
Copy link
Contributor

wardi commented Jul 3, 2024

needing to update the .env and using/not using -f docker-compose.dev.yml isn't ideal. Maybe we can use the same docker compose for both dev and prod and use a setting to switch instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants