Remove e.message deprecation warning when running tests
#3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final_response = helpers.webtest_maybe_follow(logout_response) | ||
| except Exception as e: | ||
| assert_true('/my/prefix/user/logout' in e.message) | ||
| assert_equal(logout_response.status_int, 302) |
There was a problem hiding this comment.
Isn't this already implicitly checked by supplying status in the app.get above? That will fail if the status is something other then the one given, won't it?
There was a problem hiding this comment.
Yep - totally. But I wanted to be explicit that the status is part of what we're testing.
There was a problem hiding this comment.
OK, cool. I do agree that this makes the test much more readable! 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a deprecation warning when running tests:
Which leads to this test in test_user.py.
We shouldn't need to follow the redirect to assert that a redirect is returned. Following the redirect returns a 404 in any case, because the test instance isn't mounted at
root_path, and testing the resulting exception is a bit weird.This PR removes the attempt to follow the redirect and instead tests that the appropriate url is the basis for the redirect when requesting a logout.