Prevent password reset exposing account presence #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amercader we discussed this via email in late May, just got back to it now sorry. I also have a branch with the same commit targeting dev-v2.8 if you want me to raise a PR for that too? |
This work was done in CKAN 2.7.7 by smotornyuk, just porting to other releases here.
markstuart
force-pushed
the
secure_request_reset_2.9
branch
from
9edcfab
to
b36f265
Compare
|
I'm merging this PR - it will be backported as a part of usual patch-release process, so there is no need in creating PR into 2.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was done in CKAN 2.7.7 by @smotornyuk
just porting to other releases here.
Proposed fixes:
The password reset behaviour currently behaves differently when there is no account found matching the username or email address entered in the form. This can give a malicious agent information about which accounts exist in the system and which don't.
This work makes the response to the user the same for all cases.
Features:
Please [X] all the boxes above that apply