[#4933] Fix Norwegian translation #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4933
@frafra This PR is a follow up from our discussion in #6725
In this approach, I've copied the existing
notranslation on Transifex and copied it to a newnb_NOlanguage and renamed the i18n folder in the CKAN source.I've also added a redirect for
/no/URLs to/nb_NO/Do you think this is the most sensible approach?
This will probably break sites that are currently using
noin theckan.locale_defaultconfig option. We can mention that in the CHANGELOG, or is it worth exploring keeping a symlink no -> nb_NO for compatibility?TODO on Transifex:
noover tonb_NO?nolanguage on Transifex?