Fix 404 when selecting the same date in the changes view #7191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the /dataset/id/changes_multiple page, if the user selects the same date in both select controls a 404 is returned. The case when the second date was more recent than the first one is already handled (selecting the most recent version), we just need to account for the case when both dates are the same.
amercader
added
Backport pending
zBackport 2.9.7
zBackport 2.10.0
zBackport 2.9.8
and removed
zBackport 2.9.7
labels
kowh-ai
approved these changes
Nov 14, 2022
|
@amercader - another scenario I tested was where there was just 1 update to a dataset, therefore 1 activity associated with this dataset - clicking through the "Changes" link in the Activity Stream tab also caused a 404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
/dataset/<id>/changes_multiplepage, if the user selects the same date in both select controls a 404 is returned. The case when the second date was more recent than the first one is already handled (selecting the most recent version), we just need to account for the case when both dates are the same.404_activities.mp4
This could probably be handled better with more clever select controls that update with the relevant options but this is a good first patch