Add a configurable sample size (window) for tables #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be easily observed (e.g. https://github.com/okfn/messytables/blob/master/messytables/commas.py#L123), messytables has a default size of 1000 for the sample of rows used for guessing headers and column types.
This may be not adequate for certain cases (e.g too many rows, values for a column not evenly distributed etc), so i added a simple config option
ckanext.datastorer.sample_size
to explicitly set the size of the sample. Since all processing happens in the background, i think is an acceptable cost to wait a bit longer in order have more reliable guesses (if you provide a bigger sample size),