Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configurable sample size (window) for tables #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drmalex07
Copy link

As can be easily observed (e.g. https://github.com/okfn/messytables/blob/master/messytables/commas.py#L123), messytables has a default size of 1000 for the sample of rows used for guessing headers and column types.

This may be not adequate for certain cases (e.g too many rows, values for a column not evenly distributed etc), so i added a simple config option ckanext.datastorer.sample_size to explicitly set the size of the sample. Since all processing happens in the background, i think is an acceptable cost to wait a bit longer in order have more reliable guesses (if you provide a bigger sample size),

@moqri
Copy link

moqri commented Oct 4, 2016

+1 very helpful pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants