Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ckan hooks for CKAN 2.10 support #241

Conversation

seitenbau-govdata
Copy link
Member

No description provided.

@seitenbau-govdata
Copy link
Member Author

@amercader The tests for CKAN < 2.9 and with Python 2 are now broken after merging ckan/ckanext-harvest#520 in ckanext-harvest. I assume that the tests on the master are also broken. So the changes in the pull request are independent from the failing tests.

Is there a plan to update the ckanext-dcat according to ckan/ckanext-harvest#520 in ckanext-harvest?

@pdelboca
Copy link
Member

@seitenbau-govdata We no longer support PY2 nor versions lower than 2.9. It's in our "to-do list" to clean up this extension but currently our availability is limited.

Do you have time to drop the support for old versions in this extension? I would happily review and assist you in the process

Basically:

  • Remove PY2 compatibility: six, requirements files and ifelses in the code
  • Clean commands
  • Clean controllers
  • Clean Github actions
  • Clean paster command from setup.py

@seitenbau-govdata
Copy link
Member Author

@pdelboca Ok. We'll try to make the necessary changes in a new PR.

@seitenbau-govdata
Copy link
Member Author

@pdelboca and @amercader If you agree, we would like to merge the pull request as a base for #244, because here the translation tests fail.

@seitenbau-govdata seitenbau-govdata merged commit c3c9af1 into ckan:master Apr 25, 2023
@seitenbau-govdata seitenbau-govdata deleted the update-ckan-hooks-for-ckan-2.10-support branch April 25, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants