Support for multiple agents when parsing #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for parsing iand serializing has been updated to support multiple instances by default. The behaviour in the legacy profiles of just keeping one of the instances has been kept for backwards compatibility but when using `dcat_ap_scheming` and `dcat_ap_3` profiles multiple instances of dct:publisher (although this goes against the DCAT AP spec) and dct:creator are supported.
hcvdwerf
suggested changes
Oct 28, 2024
| dct:title "Dataset 1" ; | ||
| dct:description "This is a dataset" ; | ||
| dcat:contactPoint [ a vcard:Kind ; | ||
| vcard:fn "Test Contact 1" ; |
There was a problem hiding this comment.
Could you for example add v:hasUID https://orcid.org/0000-0002-9095-9201 ; for the different contacts? Then you know also that is working
| dct:description "This is a dataset" ; | ||
| dct:publisher [ a org:Organization ; | ||
| skos:prefLabel "Test Publisher 1" ; | ||
| vcard:hasEmail <mailto:publisher1@example.org> ; |
There was a problem hiding this comment.
Same here with for example: dct:identifier "https://orcid.org/0000-0002-9095-9201" ;
hcvdwerf
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307
With the introduction of scheming repeating subfields for fields like publisher, creator, contact etc we added support for serializing (i.e. CKAN -> DCAT) but not for parsing. The logic for parsing has now been updated to support multiple instances by default. The behaviour in the legacy profiles of just keeping one of the instances has been kept for backwards compatibility but when using
dcat_ap_scheminganddcat_ap_3profiles multiple instances of dct:publisher (although this goes against the DCAT AP spec), dct:creator and dcat:contactPoint are supported.