Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change opening html element to closing. #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boykoc
Copy link

@boykoc boykoc commented Feb 7, 2019

Issue:
Currently line 16 opens a new <section> element. Browsers are adding the necessary closing tags but this results in an extra empty section element when the html is rendered:

<section class="tags">
  <ul class="tag-list">    
      <li>
        <a class="tag" href="/dataset?tags=tag">tag</a>
      </li>    
  </ul>
  <section class="tags"></section> // extra element
</section> // browser generated closing element

Suggested Change:
Change opening element to closing element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant