Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome update on CKAN 2.7 #68

Open
torfsen opened this issue Oct 2, 2017 · 1 comment
Open

FontAwesome update on CKAN 2.7 #68

torfsen opened this issue Oct 2, 2017 · 1 comment
Assignees

Comments

@torfsen
Copy link
Contributor

torfsen commented Oct 2, 2017

CKAN 2.7 uses FontAwesome 4, and there are multiple changes from version 3.

For ckanext-pages, some of these have already been taken care of by #51, but it seems that there are still some things to fix. For example, we use the edit icon from FA 3, which is now called pencil-square-o. In particular, we need to check the ckan_icon arguments to map_connect and the icon arguments to the link_for template macro.

As with #51 we need to maintain backwards-compatibility with earlier versions of CKAN. This can be done by using both the new and old FA CSS classes (e.g. class="icon-edit fa fa-pencil-square-o") or by using a custom helper function. In the latter case, we should use one helper function for all icons (pages_get_icon) instead of adding a separate helper function for each icon.

@torfsen torfsen self-assigned this Oct 2, 2017
torfsen added a commit that referenced this issue Oct 2, 2017
Some FA 4 icon names had already been added in #51, but others were
missed.
torfsen added a commit that referenced this issue Oct 2, 2017
Some FA 4 icon names had already been added in #51, but others were
missed.
torfsen added a commit that referenced this issue Oct 2, 2017
Some FA 4 icon names had already been added in #51, but others were
missed.
@nykc
Copy link

nykc commented Oct 17, 2019

Issues icon is also missing along with a few others.
I am currently using CKAN 2.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants