Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xlsx import into datastore doesn't work #161

Closed
jeverling opened this issue May 23, 2022 · 0 comments · Fixed by #175
Closed

xlsx import into datastore doesn't work #161

jeverling opened this issue May 23, 2022 · 0 comments · Fixed by #175

Comments

@jeverling
Copy link

Hi, it seems messytables does not pin the maximum version of xlrd, so xlrd 2.0.1 is installed, which removed support for XLSX files: https://xlrd.readthedocs.io/en/latest/changes.html#id1

When trying to import a xlsx file into datastore, xlrd raised an error.
The recommended fix seems to be to use openpyxl instead: https://stackoverflow.com/a/65266270
This would have to be changed in messytables. In datapusher, there was a discussion about replacing messytables altogether: ckan/datapusher#232

Is xloader supposed to support xlsx files?
@ThrawnCA ThrawnCA mentioned this issue Jul 26, 2022
Closed
ThrawnCA added a commit to qld-gov-au/ckanext-xloader that referenced this issue Sep 6, 2022
@ThrawnCA
ensure that 'datastore_active' matches the actual datastore state, ck…
c54ddac 
…an#161, QOL-9327

- On resource update, compare the flag to the actual state of the datastore, and update the flag if they don't match
ThrawnCA added a commit to qld-gov-au/ckanext-xloader that referenced this issue Sep 6, 2022
@ThrawnCA
ensure that 'datastore_active' matches the actual datastore state, ck…
d821a54 
…an#161, QOL-9327

- On resource update, compare the flag to the actual state of the datastore, and update the flag if they don't match
ThrawnCA added a commit to qld-gov-au/ckanext-xloader that referenced this issue Sep 6, 2022
@ThrawnCA
ensure that 'datastore_exists' is always set, ckan#161, QOL-9327
4292dd4
@bellisk bellisk mentioned this issue Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tabulator instead of messytables opendata-swiss/ckanext-xloader
1 participant
@jeverling