Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for unicode header names #111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

OriHoch
Copy link

@OriHoch OriHoch commented Aug 17, 2020

Currently, unicode characters in headers are encoded to ascii using unidecode library.

This PR adds a config option (ckanext.xloader.unicode_headers) which allows to keep unicode charactes in the column names

Includes new tests for this functionality + verified no regressions in existing tests

Copy link
Contributor

@davidread davidread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this contribution! Just a question about the test parameter.

ckanext/xloader/loader.py Outdated Show resolved Hide resolved
@OriHoch OriHoch requested a review from davidread August 20, 2020 12:01
@davidread davidread mentioned this pull request Oct 14, 2020
@kaplanlior
Copy link

@davidread @OriHoch

First, thanks for the PR and the review.
Can we move forward with merging it ?

Anything needed except a rebase of the branch with HEAD?

@ThrawnCA
Copy link
Collaborator

This looks good to me, but @OriHoch can you resolve the merge conflict?

@duttonw
Copy link
Collaborator

duttonw commented Oct 16, 2024

@ThrawnCA are you able to cherry pick his work and make it function. (the file that they wanted to put under test and see the result on load)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants