-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend Status Badges #224
Conversation
- Added status badges.
- Reverse debug badge logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme needs to be updated with the new config options:
ckanext.xloader.show_badges : boolean (default True)
ckanext.xloader.debug_badges : boolean (default False)
running it via qld-gov-au data.qld.gov.au site for end to end testing via qld-gov-au#108 |
Hi @JVickery-TBS , We tried this in dev.data.qld.gov.au and we already run into a bug, a i18n bug ;) Carl @ThrawnCA has raised a discussion point on having better 404 handling if a i18n file is not found (use default) https://dev.data.qld.gov.au/static/badges/en_AU/datastore-running.svg My suggestion is to ditch the images and use i18n in text form only. I.e. borrow from the validations plugin. from
to
What do you think? I'll see if I can get round to this update as what you have is very nice. (if you don't beat me to it). Regards p.s. I've just built a pypi github actions deployment pipeline (still needs improvements) but its now on ckna/ckanext-xloader :) You can read a bit more about it here: #229 |
…, remove display bug from badge display
…outer that is not rendered
2f817af
to
80999e4
Compare
feat(templates): status badges;
As promised back in February (here: #200 (comment)), this adds frontend badges stating the status of the xloadering and availability in the datastore.
Threw in the French (at least French Canadian) badges as well.