Dockerfile setup with Travis CI check and documentation update #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see this commit could help us a lot to have an up to date version of datapusher. I could help automate the build and submit process to DockerHub using Github Actions, please let me know to submit a PR ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
Fixes #136
Fixes #163
Considering datapusher is pretty-much a standalone component, it makes sense to include a Dockerfile, which can easily be extended to support all kinds of docker based deployment scenarios. The dockerfile is based on Alpine and it's using a multistage approach. Also to ensure that it doesn't break a CI test is included in Travis and basic docs.