fix(config): remove default network config set in argument (#288)

ckb-js · Jun 2, 2023 · 71a8348 · 71a8348
1 parent 3078e7c
commit 71a8348
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/packages/cli/src/main.ts b/packages/cli/src/main.ts
@@ -1,6 +1,7 @@
 #!/usr/bin/env node
 import { Command, createOption, Option } from 'commander'
 import { TaskParam, TaskArguments, initialKuai, paramTypes, KuaiArguments } from '@ckb-js/kuai-core'
+import { DEFAULT_KUAI_ARGUMENTS } from '@ckb-js/kuai-core'
 
 const KUAI_GLOBAL_PARAMS: Array<TaskParam> = [
   {
@@ -57,7 +58,7 @@ const main = async () => {
     return result
   })()
 
-  const ctx = await initialKuai(args)
+  const ctx = await initialKuai({ ...DEFAULT_KUAI_ARGUMENTS, ...args })
   const env = ctx.getRuntimeEnvironment()
   Object.values(env.tasks)
     .filter((task) => !task.isSubtask)

diff --git a/packages/core/src/config/config-loading.ts b/packages/core/src/config/config-loading.ts
@@ -40,7 +40,6 @@ export async function loadConfigAndTasks(args: KuaiArguments = {}): Promise<Kuai
     networks: DEFAULT_NETWORKDS,
     ...userConfig,
     kuaiArguments: {
-      ...DEFAULT_KUAI_ARGUMENTS,
       ...args,
       configPath,
     },

diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -7,3 +7,4 @@ export { KuaiContext } from './context'
 export * from './typescript-support'
 export * from './helper'
 export * from './util'
+export * from './constants'
diff --git a/packages/samples/mvp-dapp/.env.example b/packages/samples/mvp-dapp/.env.example
@@ -4,9 +4,7 @@ PORT=3000
 
 # ckb
 CKB_RPC_URL=https://testnet.ckb.dev/rpc
-
-# lumos
-LUMOS_CONFIG=aggron4
+NETWORK=testnet
 
 # redis
 REDIS_PORT=6379