-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common-scripts): sudt data may over 16 bytes #549
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Not an issue, just out of curious: does the changesets need a strong format? For example, I see the lumos' changeset messages are like this: "doing something". I'm also using changesets, wonder if it matters. |
Codecov Report
@@ Coverage Diff @@
## develop #549 +/- ##
========================================
Coverage 86.35% 86.35%
========================================
Files 114 114
Lines 22917 22928 +11
Branches 2310 2312 +2
========================================
+ Hits 19790 19800 +10
- Misses 3084 3086 +2
+ Partials 43 42 -1
Continue to review full report in Codecov by Sentry.
|
No, the changesets has no restrictions on the format, here is an example |
.changeset/orange-flowers-sort.md
Outdated
"@ckb-lumos/common-scripts": patch | ||
--- | ||
|
||
enable ACP to work with cells with more than 16 bytes of data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enable ACP to work with sUDT cells with more than 16 bytes of data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
better add test case in |
Signed-off-by: Yonghui Lin <homura.dev@gmail.com>
Do we need to update the example: |
Description
Fixes #548
the data of an sUDT cell may be over 16 bytes but it is still valid, so we should slice the first 16 bytes as the sUDT amount
Type of change