Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade and add dj stripe #40
base: master
Are you sure you want to change the base?
upgrade and add dj stripe #40
Changes from 9 commits
2d3ce59
a11cdbd
a0bf39c
cbabfcf
431de85
e0afde3
c35fb15
493f187
076cb28
919c664
b0a187f
a8a11d8
94ffc1d
f87855f
36615d1
a780bbb
7d52c69
2a1808b
c992749
a3a67c0
6f43a1f
e60147e
fc6645f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull, or useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo, should we really let this pass? I think we should let this be raised, and handle it with
ValidationError
wrappers at a certain point?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think we don't need this
utils/
subdir?payments.py
, andsubscriptions.py
could live right inckc.stripe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any error handling needed in this function? we can have some fun soon trying to cause all kinds of problems and handle them nicely .. then never have to handle them again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this optional, lots of other projects don't use stripe
So we can install
django-ckc
without also installing stripe, unless we dodjango-ckc[stripe]
or something