Patch test #1
Merged
Patch test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, you see this error when attempting to use an HTTPS proxy. `Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: Host: foo.com. is not in the cert's altnames: DNS:*.bar.com, DNS:bar.com` The `servername` attribute is able to fix this behavior when passed to the underlying `tls.connect()` call inside of the `https` module. (see the Node [docs](https://nodejs.org/api/https.html#httpsrequesturl-options-callback)) This was very painful to debug but now I understand how `CONNECT` works extremely well! Cheers. FIxes delvedor#43
|
Not sure why Node.JS v10 tests are failing... seems it is somehow trying to check cert... will investigate |
|
Turns out node v10 will inherit the HTTP hostname when doing HTTP over HTTPS (proxy is TLS) , which was breaking it. Added @freeqaz 's fix to the HttpProxyAgent as well! |
|
Fucking windows now... aight let me boot into my win machine :ded: |
|
LETS FUCKING GOOOO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make self signed certs with hostnames, node.js trust certs, actual tls verification, fix unit tests