-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Consumption of Non-Webpacked Source Code #180
Comments
Hi @sbulley09 , Thank you for the proposal. At this point I can tell that we won't work on such a solution - so I close this issue. Please, notice that we have to provide a complete solution that works in many different environments. |
Would it be possible to both export the original (or transpiled) files in addition to the webpack bundle? Really, we are looking to do the webpacking ourselves as we have unique needs that aren't being covered by the webpack bundle that this project is providing. |
@sbulley09 , @ryanthemanuel |
We can simply publish |
We were thinking about such solution. Theoretically, one can simply use GitHub repo with
I guess this would be more "proper" solution so it can be consumed easier as it's integrated into standard workflows. Not sure about backwards compatibility and |
Hi @sbulley09 and @ryanthemanuel, This is already covered in new RC version available already on NPM. Feel free to check how it works - your feedback on this is more than welcome. You can find documentation on a new version here. |
Hi @sbulley09 and @ryanthemanuel, The RC version previously mentioned in #180 (comment) has been released as Fixed in |
Are you reporting a feature request or a bug?
Feature Request
Request Details
Currently, the only method of consumption is via the webpacked bundle in the dist folder. This webpack bundle includes a polyfill babel polyfill set up via the usage method. This ends up adding a polyfill for Promises but not for the 'finally' functionality of promises since those are not used within the code. One of our solutions relies on a promise polyfill which is a different polyfill than the provided by babel.
Since the incomplete babel polyfill is loaded first without all the functionality, it doesn't get overwritten by our polypill and thus we end up with the 'finally' functionality missing. As a work around, we've copied the source code into our own project which allows us to use our internal strategy of building projects. This comes with the downside of having to continually update our internal fork over time and maintain that ourselves. It would be ideal for us to be able to consume the non-webpacked source and be able to apply our own polyfills as needed.
The text was updated successfully, but these errors were encountered: