Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdowns reflect only the beginning / start of selection. #525

Open
jswiderski opened this issue Jun 19, 2017 · 5 comments
Open

Dropdowns reflect only the beginning / start of selection. #525

jswiderski opened this issue Jun 19, 2017 · 5 comments
Assignees
Labels
status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Milestone

Comments

@jswiderski
Copy link
Contributor

jswiderski commented Jun 19, 2017

Are you reporting a feature or a bug?

Feature request

Check if the issue is already reported

https://dev.ckeditor.com/ticket/13553

Provide detailed reproduction steps (if any)

  1. Create 3 paragraphs with 3 different fonts e.g.
<p><span style="font-family:Comic Sans MS,cursive">test1</span></p>
<p><span style="font-family:Georgia,serif">test2</span></p>
<p><span style="font-family:Lucida Sans Unicode,Lucida Grande,sans-serif">test3</span></p>
  1. Select all content

Expected result

Font dropdown doesn't show any font.

Actual result

Font dropdown shows font from first paragraph.

Other details

  • Browser: all
  • OS: all
  • CKEditor version: 4.0+
  • Installed CKEditor plugins:

NOTE: This is how selection and styles work in the editor. Dropdowns always reflect beginning of selection. Perhaps here we could check if selection contains something more than one element and more than one font and if it does, simply not showing any font. Same goes for font-size, format and styles.

@jswiderski jswiderski added status:confirmed An issue confirmed by the development team. type:feature A feature request. support An issue reported by a commercially licensed client. labels Jun 19, 2017
@mlewand
Copy link
Contributor

mlewand commented Jun 27, 2017

The feature sounds reasonable, though it's not crucial for us ATM. We can get back to it at some point.

@mlewand mlewand added this to the Backlog milestone Jul 6, 2017
@Comandeer
Copy link
Member

I've prepared the first, WIP implementation of this feature for font plugin, it's on t/525 branch. It's already integrated with tableselection plugin (or, more generally speaking, multiple ranges).

However there are some issues with new selection from the same element as the first one. Due to the fact how our selectionChange works it's impossible to correctly detect changes. It would probably require some major changes in richcombo plugin.

There is also need to implement this feature also for format and styles plugins.

@akashbiz
Copy link

+1 Facing same issue for font size, any update on this?

@mlewand
Copy link
Contributor

mlewand commented Apr 18, 2018

@akashbiz please add 👍 reaction to the main comment of this issue. As for the updates you can see that it has been tackled in #745 but it has not been updated recently. You can always apply the code from that PR and use patched version if it's important for you.

@mlewand
Copy link
Contributor

mlewand commented Apr 18, 2018

There are plenty of tutorials on how to do that around the need, google around and I'm sure you'll find it.

@lslowikowska lslowikowska added support:1 An issue reported by a commercially licensed client. and removed support An issue reported by a commercially licensed client. labels Dec 21, 2018
@f1ames f1ames removed the target:major Any docs related issue that should be merged into a major branch. label Nov 12, 2019
@lslowikowska lslowikowska added support:2 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

6 participants