Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set default font family/size if selection does not start inside styling span #1116

Open
f1ames opened this issue Nov 3, 2017 · 1 comment
Labels
plugin:font The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@f1ames
Copy link
Contributor

f1ames commented Nov 3, 2017

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

Related to #525 and #584.

Provide detailed reproduction steps (if any)

  1. Go to http://nightly.ckeditor.com/17-11-03-07-04/full/samples/.
  2. Set content to <p>foo <span style="font-size:20px">bar</span> baz</p> .
  3. Select <p>f{oo <span style="font-size:20px">bar</span> b}az</p> .
  4. Open font size dropdown and apply (Default).

Expected result

Selected text font size is changed to default one.

Actual result

Selected text font size does not change.

Before change in #584, this issue was not visible. Removing the size was done by toggling option in a dropdown, however when selection does not start in the styling span the dropdown was not highlighting the proper item (which #525 is now trying to solve) so it was not possible to toggle.

Other details

  • Browser: All
  • OS: All
  • CKEditor version: 4.8.0 (major not yet released)
  • Installed CKEditor plugins: font
@f1ames f1ames added plugin:font The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. plugin:stylescombo The plugin which probably causes the issue. and removed plugin:font The plugin which probably causes the issue. labels Nov 3, 2017
@f1ames f1ames added plugin:font The plugin which probably causes the issue. and removed plugin:stylescombo The plugin which probably causes the issue. labels Nov 20, 2017
msamsel pushed a commit that referenced this issue Sep 6, 2019
…described in #1116 and ignore test related with this bug.
msamsel pushed a commit that referenced this issue Sep 6, 2019
…described in #1116 and ignore test related with this bug.
msamsel pushed a commit that referenced this issue Dec 19, 2019
…described in #1116 and ignore test related with this bug.
msamsel pushed a commit that referenced this issue Dec 20, 2019
…described in #1116 and ignore test related with this bug.
msamsel pushed a commit that referenced this issue Jan 8, 2020
…described in #1116 and ignore test related with this bug.
jacekbogdanski pushed a commit that referenced this issue Jan 13, 2020
…described in #1116 and ignore test related with this bug.
@msamsel
Copy link
Contributor

msamsel commented Jan 16, 2020

It might be helpful to check this commit. There are removed parts, which initially I want to use to fix this bug together with introducing font commands.
1b67e6a

jacekbogdanski pushed a commit that referenced this issue Jan 22, 2020
…described in #1116 and ignore test related with this bug.
@jacekbogdanski jacekbogdanski added this to the Planning milestone Jan 22, 2020
@f1ames f1ames removed this from the Planning milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:font The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants