Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using File Transfer with PFW image #1059

Closed
wants to merge 43 commits into from
Closed

Using File Transfer with PFW image #1059

wants to merge 43 commits into from

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Oct 17, 2017

What is the purpose of this pull request?

New feature

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

  • use file transfer to embed images from word

Related to #662

Mateusz Samsel and others added 30 commits September 21, 2017 15:29
Hexstring converter to base64
- extract test data to separate files and update test cases for using it
- remove unnecessary file with fixtures
- little code improvements
- update test for using more fixtures
- update docs
- rename variables
- small code improvements
Image extraction methods for PFW Images plugin
Rename test cases to be meaningful
@mlewand
Copy link
Contributor

mlewand commented Nov 24, 2017

We decided that uploading will be done with the Upload Image plugin. Thus we no longer need this ingeration next to Paste from Word code responsible for inlining images. Thus closing this PR as expired.

@mlewand mlewand closed this Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants