#9929: [Chrome 23] is created when deleting character and typing common space #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng common space It seems as is a result of altering source for checkStartOfBlock()/checkEndOfBlock(). Changing order of checks in if checkStartOfBlock()/checkEndOfBlock() are run only when necessary, not every time del/backspace is pressed.
|
Thanks! We're gonna review your patch and merge it if everything's fine. |
|
Any news on this? |
Allowing attribute check for elements gives a possibility to match elements with specific attribute. This is handy for creating complex custom templates and accessing them later on. I'm creating templatesExtended plugin which relies on this behavior. This only supports check for one attribute.
|
@niklam you appear to have added an unrelated commit to this pull request. This is probably because you made the pull request from your master branch. When you make a pull request in github off of one of your branches, github will monitor changes to that branch and update the PR accordingly. Better practice is to create a bug-fix pull request and submit that. At this point it might be worth closing and reopening the pull request on a branch specific to this bug. |
|
Ok, I did that. The new pull request is pull request #60. |
|
So I'm closing this pull request. Thanks. |
mdenburger
pushed a commit
to onehippo/ckeditor
that referenced
this pull request
May 23, 2014
jacekbogdanski
pushed a commit
that referenced
this pull request
Aug 10, 2021
Revert "Merge pull request #39 from cksource/sec/38"
jacekbogdanski
added a commit
that referenced
this pull request
Aug 21, 2024
Bump year in the license headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems as is a result of altering source by checkStartOfBlock()/checkEndOfBlock() using trim(). Changing order of checks in if() checkStartOfBlock()/checkEndOfBlock() are run only when necessary, not every time del/backspace is pressed.