Fix for pasting lists from OneNote #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
suggested changes
Sep 4, 2017
There was a problem hiding this comment.
Couple of minor things. On top of that:
I'd rather like to have some sort original fixture in OneNote's format. But AFAICS OneNote doesn't provide the feature to save stuff locally? Can we reproduce the exact same markup using Word? Then we could store a .docx.
| ( function() { | ||
| 'use strict'; | ||
|
|
||
| var config = { |
There was a problem hiding this comment.
No need to extract config here, just inline it - we're doing it very often and it's well readable.
| @@ -0,0 +1,38 @@ | |||
| /* bender-tags: clipboard,pastefromword */ | |||
| /* jshint ignore:start */ | |||
There was a problem hiding this comment.
I see no reason to ignore this line in JSHint.
| var config = { | ||
| language: 'en', | ||
| colorButton_normalizeBackground: false, | ||
| allowedContent: 'p ul li' |
There was a problem hiding this comment.
Rather than define explicitly allowedContent, just add list plugin, and that will be fine.
| 'OneNote' | ||
| ], | ||
| tests: { | ||
| 'OneNote': true |
There was a problem hiding this comment.
Test case name need to say what it's doing. In this case we're working with lists.
|
I've analysed OneNote and Word. I wasn't able to reproduce similar situation in case of Word. Word2016 & Word2013: OneNote: |
mlewand
suggested changes
Sep 12, 2017
- remove jshint ignore comment - change config for tests - add list plugin instead of using allowedContent - rename test suite
mlewand
changed the title
mlewand
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
correctLevelShiftprocess lists. To append elements at the end instead of always at the beginning.close #796