Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit and note groups should be sorted properly #653

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Commit and note groups should be sorted properly #653

merged 2 commits into from
Jun 29, 2020

Conversation

pomek
Copy link
Member

@pomek pomek commented Jun 25, 2020

Suggested merge commit message (convention)

Fix (env): Commit and note groups should be sorted properly. Closes ckeditor/ckeditor5#7496.

@pomek pomek requested a review from mlewand June 25, 2020 12:42
@coveralls
Copy link

coveralls commented Jun 25, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 87.805% when pulling eff7afe on i/7496 into 0d0a371 on master.

mlewand
mlewand approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlewand mlewand merged commit a08020c into master Jun 29, 2020
@mlewand mlewand deleted the i/7496 branch June 29, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlewand mlewand mlewand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changelog's "Major breaking changes" section should be before minor BC
3 participants
@pomek @coveralls @mlewand